Validate ELF Build IDs Before Symbol-Cache Path Construction - #2461
Open
Brian Robbins (brianrob) wants to merge 1 commit into
Open
Validate ELF Build IDs Before Symbol-Cache Path Construction#2461Brian Robbins (brianrob) wants to merge 1 commit into
Brian Robbins (brianrob) wants to merge 1 commit into
Conversation
Brian Robbins (brianrob)
commented
Aug 26, 2026
Brian Robbins (brianrob)
commented
Member
- Validate ELF build IDs before constructing symbol-server or cache paths
- Accept 8-20-byte hexadecimal IDs and normalize them to canonical 40-character SSQP keys
- Reject malformed, rooted, or traversal-containing values explicitly
- Ensure resolved ELF cache paths remain within the configured symbol-cache directory
- Add focused validation, normalization, and containment tests
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0607fc9e-797e-42c7-9c6e-27cce2fd6ffd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.